Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@DuYongLee, thanks for this.

@tazarov Thanks for your checking. it had a conflict so I resolved it.

@DuYongLee weird github issue where the test suite didnt run (cant merge without it...). - can you bump a commit to this to retrigger them? (add whitespace to a README or something) id be happy to do it but im on an airplane and the wifi is terrible :)

@jeffchuber I think this issue needs to be approved by tazarov or removed from reviewer.
I made a bump commit but there is no response.